test/replacers.test.ts (1)

1128-1128: ⚡ Quick win

Use DEFAULT_PATTERN_MASK instead of hardcoded mask literals.

These two assertions hardcode '**********', which makes tests brittle if the default mask changes.

Proposed fix

-        expect(sanitized.get('message')).toBe('api_key=**********');
+        expect(sanitized.get('message')).toBe(
+          `api_key=${DEFAULT_PATTERN_MASK}`,
+        );

-        expect(sanitized.has('api_key=**********')).toBe(true);
+        expect(
+          sanitized.has(`api_key=${DEFAULT_PATTERN_MASK}`),
+        ).toBe(true);

Also applies to: 1231-1231

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/replacers.test.ts` at line 1128, The test is asserting a hardcoded mask
string ('**********') which should use the shared DEFAULT_PATTERN_MASK constant
to avoid brittleness; update the two assertions that check
sanitized.get('message') (and the other occurrence at the second mentioned
location) to compare against DEFAULT_PATTERN_MASK instead of the literal
'**********' so the test follows the current default mask value (import or
reference DEFAULT_PATTERN_MASK in tests if not already imported).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

test/replacers.test.ts (2)

1194-1274: 💤 Low value

Optionally add tests for removeMatches and scanStringValues: false with Sets.

For additional coverage completeness:

1. removeMatches with Set string scanning — When a Set contains 'api_key=hunter2' and removeMatches: true, verify the behavior (likely produces empty string from the scan-and-remove logic).

2. scanStringValues: false with Set — Verify that when scanStringValues: false, string items in Sets are not scanned for embedded patterns, consistent with plain object behavior (tested at line 956-973).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/replacers.test.ts` around lines 1194 - 1274, Add two new tests under the
existing "Set sanitization" describe that call objectReplacer with
sanitizeCollections: true and reference DEFAULT_PATTERN_MASK: one test sets
removeMatches: true and a Set containing 'api_key=hunter2' and asserts the Set
item is removed or becomes the expected empty/removed-result per the
scan-and-remove logic (use removeMatches flag passed to objectReplacer); the
other test sets scanStringValues: false with a Set containing 'api_key=hunter2'
and asserts the string is left unchanged (i.e., still 'api_key=hunter2'),
mirroring the behavior asserted for plain objects; locate usages near the other
Set tests so they use the same patterns and assertions.

---

1036-1274: ⚡ Quick win

Consider adding tests for circular references and non-plain object preservation.

The Map and Set test coverage is solid for the main scenarios. However, two important edge cases are missing that align with the coding guidelines:

1. Circular reference detection — The implementation uses WeakSet to detect circular references and throws TypeError. Add tests like:

   const circularMap = new Map();
   circularMap.set('self', circularMap);
   expect(() => objectReplacer({ data: circularMap }, { sanitizeCollections: true }))
     .toThrow(TypeError);

2. Non-plain object preservation in collections — Per guidelines, non-plain objects (e.g., Date, custom classes) should pass through unchanged. The test at line 754-796 verifies this when sanitizeCollections is false, but not when it's true. Add tests like:

   const date = new Date('2024-01-01');
   const map = new Map([['timestamp', date], ['username', 'mark']]);
   const result = objectReplacer({ map }, { sanitizeCollections: true });
   const sanitized = result.map as Map<string, unknown>;
   expect(sanitized.get('timestamp')).toBe(date); // same instance

As per coding guidelines, object replacers must detect circular references and preserve non-plain object instances.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/replacers.test.ts` around lines 1036 - 1274, Add two tests for
collection handling: (1) verify circular reference detection by creating a
Map/Set that contains itself and asserting objectReplacer({ data: circular }, {
sanitizeCollections: true }) throws a TypeError (this exercises the
WeakSet-based cycle detection inside objectReplacer); (2) verify non-plain
objects are preserved when sanitizeCollections is true by putting a Date (or
custom class instance) into a Map/Set alongside a normal key and asserting the
sanitized collection contains the exact same Date instance (not cloned or
modified) while other sensitive entries are masked; place these alongside the
existing Map/Set tests referencing objectReplacer and the sanitizeCollections
option.